Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement like api #61

Merged
merged 3 commits into from
Mar 19, 2021
Merged

Implement like api #61

merged 3 commits into from
Mar 19, 2021

Conversation

zych1751
Copy link
Collaborator

  • like 모델 구조 변경
  • 다른 api에서 에러메시지 보낸 이후에 함수가 끝나지 않는 버그 수정
  • 좋아요/좋아요 취소 api 구현

#26
video 별로 전체 좋아요 개수 세는걸 정확히 어떻게 할 지 얘기해보면 좋을 것 같습니다.

cron으로 한다고 했었는데 매번 모든 포스트를 검색해야 할지,
아니면 들어오는 좋아요, 좋아요 취소 요청을 모두 따로 기록해서 pub/sub 같은 구조로 해도 괜찮아 보이기도 했습니다.

@zych1751
Copy link
Collaborator Author

회의에서 말한대로 우선 바로 Video의 totalLikes를 바꾸게 반영했고, #62 를 추후에 처리.

@zych1751 zych1751 requested a review from hywook4 March 15, 2021 14:03
Copy link
Contributor

@hywook4 hywook4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zych1751 zych1751 merged commit e96d2e4 into master Mar 19, 2021
@hywook4 hywook4 deleted the feature/like branch April 21, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants