This repository has been archived by the owner on Dec 18, 2019. It is now read-only.
add fix for webdriverIO bug 2639 #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -4,6 +4,7 @@ wdio-sync | |||
| [](https://travis-ci.org/webdriverio/wdio-sync) [](https://codeclimate.com/github/webdriverio/wdio-sync) [](https://codeclimate.com/github/webdriverio/wdio-sync/coverage) [](https://www.versioneye.com/user/projects/58ba933101b5b7004a7b5b8d) | |||
|
|
|||
| *** | |||
| *This is a modified version of the wdio-sync with an enhanced stack trace functionality. All of the rights belong to the wdio team. | |||
There was a problem hiding this comment.
Not sure if this line is necessary.
| try { | ||
| var line = Object.getPrototypeOf(Object.getPrototypeOf(e)).constructor.caller | ||
| } catch (e) { | ||
| myStackTrace = e.stack.split('\n').slice(2, e.stack.split('\n').length).join('\n'); |
There was a problem hiding this comment.
What would e.stack and myStackTrace look like here?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for webdriverIO bug 2639 regarding details in error stack traces. All the tests pass and no core functionality is affected. Only added effect is that the line at which a test fails is added which helps a lot.
I've added a comment to the issue containing an initial version of the fix and an example of output.
I've also tested this extensively in real usage scenarios and with no ill effects.