Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(create-wdio): fix project name on Windows #591

Merged
merged 1 commit into from
Dec 6, 2023
Merged

(create-wdio): fix project name on Windows #591

merged 1 commit into from
Dec 6, 2023

Conversation

erwinheitzman
Copy link
Member

  • fixed issue where the package.json name would contain the full path instead of the directory name on Windows

@erwinheitzman erwinheitzman merged commit 545eb05 into webdriverio:main Dec 6, 2023
5 checks passed
@erwinheitzman erwinheitzman deleted the fix-project-name branch December 6, 2023 22:00
christian-bromann
christian-bromann reviewed Dec 6, 2023
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erwinheitzman @christian-bromann