fix(app-headless-cms): remove delete callback memoization

webiny · Dec 23, 2024 · 3cc4b02 · 3cc4b02
1 parent a246137
commit 3cc4b02
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 20 deletions.
diff --git a/packages/app-headless-cms/src/admin/components/ContentEntryForm/useBind.tsx b/packages/app-headless-cms/src/admin/components/ContentEntryForm/useBind.tsx
@@ -101,8 +101,11 @@ export function useBind({ Bind, field }: UseBindProps) {
                                     if (index < 0) {
                                         return;
                                     }
-                                    let value = bind.value;
-                                    value = [...value.slice(0, index), ...value.slice(index + 1)];
+
+                                    const value = [
+                                        ...bind.value.slice(0, index),
+                                        ...bind.value.slice(index + 1)
+                                    ];
 
                                     bind.onChange(value.length === 0 ? null : value);
 

diff --git a/packages/app-headless-cms/src/admin/plugins/fieldRenderers/object/multipleObjects.tsx b/packages/app-headless-cms/src/admin/plugins/fieldRenderers/object/multipleObjects.tsx
@@ -68,15 +68,12 @@ const Actions = ({ setHighlightIndex, bind, index }: ActionsProps) => {
         [moveValueUp, index]
     );
 
-    const onDelete = useCallback(
-        (ev: React.BaseSyntheticEvent) => {
-            ev.stopPropagation();
-            showConfirmation(() => {
-                bind.field.removeValue(index);
-            });
-        },
-        [index]
-    );
+    const onDelete = (ev: React.BaseSyntheticEvent) => {
+        ev.stopPropagation();
+        showConfirmation(() => {
+            bind.field.removeValue(index);
+        });
+    };
 
     return (
         <>

diff --git a/...ges/app-headless-cms/src/admin/plugins/fieldRenderers/object/multipleObjectsAccordion.tsx b/...ges/app-headless-cms/src/admin/plugins/fieldRenderers/object/multipleObjectsAccordion.tsx
@@ -70,15 +70,12 @@ const Actions = ({ setHighlightIndex, bind, index }: ActionsProps) => {
         [moveValueUp, index]
     );
 
-    const onDelete = useCallback(
-        (ev: React.BaseSyntheticEvent) => {
-            ev.stopPropagation();
-            showConfirmation(() => {
-                bind.field.removeValue(index);
-            });
-        },
-        [index]
-    );
+    const onDelete = (ev: React.BaseSyntheticEvent) => {
+        ev.stopPropagation();
+        showConfirmation(() => {
+            bind.field.removeValue(index);
+        });
+    };
 
     return (
         <>