-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app-headless-cms): add object and DZ renderer settings #4155
feat(app-headless-cms): add object and DZ renderer settings #4155
Conversation
BREAKING CHANGE: none Refs: webiny#4109
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one little change here and we're good to go.
On the topic of mutation error, the settings should be either undefined
, or an object. I will have a look at this right there in your PR, and will push a fix for this, so we expedite merging of this PR.
Thank you!
packages/app-headless-cms/src/admin/plugins/fieldRenderers/object/multipleObjectsAccordion.tsx
Outdated
Show resolved
Hide resolved
@ma-schmidt-de I pushed a fix for that issue with existing fields, so |
…dz-and-object' into feature/4109-add-open-config-to-dz-and-object
@Pavel910 thanks for adding the fix! I polished the code style according to your feedback. |
It's approved, let's wait for CI to finish, and we'll merge it then. |
Thanks @ma-schmidt-de for your contribution! Looking forward to more of these!! 🚀 |
Changes
Okay, this is the 2nd iteration of the new feature to expand object and dynamic zone HCMS fields by default. According to @Pavel910's recommendation, I'm using the new renderer settings feature to define an
open
attribute. If this attribute is set totrue
, the accordion of the object or dynamic zone field is expanded.BREAKING CHANGE: none
Closes: #4109
How Has This Been Tested?
Manually, with an in-code content model.
![Screenshot 2024-06-05 at 20 16 10](https://private-user-images.githubusercontent.com/19306046/336958293-680598d8-906b-47c6-859d-c16fa80d5f50.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNjUwNjIsIm5iZiI6MTczOTE2NDc2MiwicGF0aCI6Ii8xOTMwNjA0Ni8zMzY5NTgyOTMtNjgwNTk4ZDgtOTA2Yi00N2M2LTg1OWQtYzE2ZmE4MGQ1ZjUwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDA1MTkyMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU0ODcwZDkxNzRmNzY2NjI0NjY3NDk3YjVjM2FhM2Q5YmYzZjI5N2QxNzgyZTIxNzMwN2MxNGVkODAxNmM3NmEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.4TG4pFQsxbOOa7zUuOtKaoksYkvmROAzCeHUZF_eBR8)
Documentation
We could use this implementation as an example for the section that describes the renderer settings feature.