-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Old publishedOn
and ownedBy
GraphQL Fields (Instead of Removing Them) and Make New Meta GraphQL Fields Nullable
#4156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, we're removing the logger just so redundant logs are no longer printed in CloudWatch. In the near future, we'll have our own Pino logger that we'll pass to Fastify.
…gration-logs-flag
…gration-script-using-mt
…gration-script-using-mt
…' into adrian/migration-script-using-mt
…webiny-js into adrian/migration-script-using-mt
…ted-gql-meta-fields
…-script-using-mt-2
…-script-using-mt-2
…ted-gql-meta-fields
…s' into adrian/deprecated-gql-meta-fields
…-script-using-mt-2
…ted-gql-meta-fields
…' into adrian/migration-script-using-mt
…-script-using-mt-2
…ted-gql-meta-fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With this PR, we're bringing back the removed
publishedOn
andownedBy
GraphQL fields, just so existing users have a fallback when upgrading to 5.39.We've also made the new meta GraphQL fields nullable. This makes it possible for users to use the Admin app even while their system is being data migrated.
How Has This Been Tested?
Manually.
Documentation
Changelog.