Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): trim quotes when reading tenant id #4326

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

brunozoric
Copy link
Contributor

Changes

When getting a tenant via the @webiny/app/utils/getTenantId method, and it is fetched from the local storage, it has quotes around the value. This fix will remove those quotes either via JSON.parse or just stripping the quotes.

How Has This Been Tested?

Manually.

@brunozoric brunozoric requested a review from Pavel910 October 10, 2024 07:26
@brunozoric brunozoric self-assigned this Oct 10, 2024
@brunozoric brunozoric added this to the 5.41.0 milestone Oct 10, 2024
@brunozoric brunozoric marked this pull request as ready for review October 10, 2024 07:26
@brunozoric brunozoric changed the title fix(app): when fetching tenant from local storage it has quotes fix(app): trim quotes when reading tenant id Oct 10, 2024
@brunozoric brunozoric merged commit 65fd703 into next Oct 10, 2024
3 of 13 checks passed
@brunozoric brunozoric deleted the bruno/fix/app/get-tenant-id branch December 5, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant