Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app-admin): hide tooltip for disabled icon button #4327

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

leopuleo
Copy link
Contributor

Changes

With this pull request, we remove the IconButton tooltip if the component receives a disabled prop.

Context

IconButton is used to trigger a bulk action. Developers can programmatically disable a button to prevent the action trigger. This PR improves the UI by removing the tooltip as shown in the video.

CleanShot.2024-10-10.at.10.33.45.mp4

How Has This Been Tested?

Manually

@leopuleo leopuleo added this to the 5.41.0 milestone Oct 10, 2024
@leopuleo leopuleo self-assigned this Oct 10, 2024
@leopuleo leopuleo merged commit c2bad0d into next Oct 10, 2024
95 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants