Add Warning - Watching Admin/Website Without Having API Deployed #4350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrians5j
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Prior to this PR, we had this PR that was supposed to block watching Admin/Website apps in case API was not deployed.
Turns out, this does not work for users that might be connecting their locally started Admin/Website app to a shared / already deployed API, which can be done via a couple of customizations via respective
webiny.config.tsfiles. Those users would basically get blocked.Because of this, I've removed the before-watch checks that the linked PR introduced. Instead, I've added a check in app config factories. Basically, in case stack output was not retrieved successfully, a warning message will be displayed in the console.
This way, the user won't get blocked.
Note
It would be nice if some day we were able to introduce a more straightforward way of connecting locally started Admin/Website apps to a shared / already deployed API.
How Has This Been Tested?
Manually.
Documentation
Changelog.