Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin-ui): Select component #4365

Merged
merged 28 commits into from
Nov 21, 2024
Merged

Conversation

leopuleo
Copy link
Contributor

@leopuleo leopuleo commented Nov 5, 2024

Changes

This pull request adds the Select component to the @webiny/admin-ui package. Subsequent pull requests will develop the Select form variant and Autocomplete components.

How Has This Been Tested?

Manually - Jest

Copy link

Cypress E2E tests have been initiated (for more information, click here). ✨

@webiny webiny deleted a comment from github-actions bot Nov 14, 2024
Copy link

Cypress E2E tests have been initiated (for more information, click here). ✨

@webiny webiny deleted a comment from github-actions bot Nov 14, 2024
Copy link

Cypress E2E tests have been initiated (for more information, click here). ✨

@webiny webiny deleted a comment from github-actions bot Nov 14, 2024
Copy link

Cypress E2E tests have been initiated (for more information, click here). ✨

@leopuleo
Copy link
Contributor Author

/storybook

@leopuleo leopuleo marked this pull request as ready for review November 14, 2024 13:26
@leopuleo leopuleo self-assigned this Nov 14, 2024
@leopuleo leopuleo added the ui label Nov 14, 2024
Copy link

🚀 Storybook Preview
You can preview the Storybook by visiting the link below:

Storybook Preview URL

Copy link
Member

@adrians5j adrians5j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote some feedback, but it's basically just questions / trying to understand all bits and pieces. I didn't see anything that would block the merge, so I also approved.

There are some things that I wrote based on intuition, not on exp / knowledge, so that might be off. And I totally get that we probably don't want to spend too much time on chasing the "perfect" arch / code and having dubious conversations which at the end of the day don't bring any real value. 🙃

packages/admin-ui/src/Select/index.ts Show resolved Hide resolved
packages/admin-ui/src/Select/SelectPresenter.ts Outdated Show resolved Hide resolved
packages/admin-ui/src/Select/SelectPresenter.ts Outdated Show resolved Hide resolved
packages/admin-ui/src/Select/useSelect.ts Outdated Show resolved Hide resolved
packages/admin-ui/src/Select/SelectPresenter.ts Outdated Show resolved Hide resolved
packages/admin-ui/src/Select/Select.tsx Show resolved Hide resolved
@leopuleo leopuleo merged commit c31987f into feat/new-admin-ui Nov 21, 2024
16 checks passed
@leopuleo leopuleo deleted the leo/feat/ui-select branch December 5, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants