-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(admin-ui): Select component #4365
Conversation
Cypress E2E tests have been initiated (for more information, click here). ✨ |
Cypress E2E tests have been initiated (for more information, click here). ✨ |
Cypress E2E tests have been initiated (for more information, click here). ✨ |
Cypress E2E tests have been initiated (for more information, click here). ✨ |
/storybook |
🚀 Storybook Preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote some feedback, but it's basically just questions / trying to understand all bits and pieces. I didn't see anything that would block the merge, so I also approved.
There are some things that I wrote based on intuition, not on exp / knowledge, so that might be off. And I totally get that we probably don't want to spend too much time on chasing the "perfect" arch / code and having dubious conversations which at the end of the day don't bring any real value. 🙃
Changes
This pull request adds the
Select
component to the@webiny/admin-ui
package. Subsequent pull requests will develop theSelect
form variant andAutocomplete
components.How Has This Been Tested?
Manually - Jest