Page Builder - Improving Text Rendering on Rendered Pages #4402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrians5j
changed the title
Pavel910
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds two patches.
1. Improving Text Rendering on Rendered Pages
First, it ensures that the old Medium editor (used before we introduced Lexical into PB), does not render anything if the received content is recognized as JSON. Without this fix, on rendered pages, users would sometimes be able to see a JSON string being printed for a brief amount of time (a couple of ms).
Note that there is still some work to be done here, which will be done in the near future.
2. Added
@babel/plugin-proposal-dynamic-importTo Babel Configuration For React AppsAs the title says, we've added
@babel/plugin-proposal-dynamic-importto Babel configuration that's used with React apps.How Has This Been Tested?
Manually.
Documentation
Changelog.