Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve multi value field renderers #4404

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Conversation

Pavel910
Copy link
Collaborator

Changes

This PR is focusing on multi-value field renderers in the Headless CMS. The DynamicSection component no longer adds the initial item UI, which was causing many issues with validation, and users were unable to remove that first item, which was also unintuitive.

The labels and behavior is now standardized across all multi-value renderers, the field label looks the same, prints help text in the same place across all fields, and also counts the number of items in the data set. The initial UI is no longer added, and users can remove all items from the data set.

image

How Has This Been Tested?

Manually.

@Pavel910 Pavel910 added this to the 5.41.2 milestone Nov 20, 2024
@Pavel910 Pavel910 requested a review from adrians5j November 20, 2024 17:57
@Pavel910 Pavel910 self-assigned this Nov 20, 2024
@Pavel910
Copy link
Collaborator Author

/cypress

Copy link

Cypress E2E tests have been initiated (for more information, click here). ✨

@Pavel910 Pavel910 merged commit e2f2ea3 into dev Nov 21, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant