Deployments - Skip 'First Deployment" Check When In CI #4408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When users deploy their project for the first time via the
![image](https://private-user-images.githubusercontent.com/5121148/389021942-56479f86-70e8-4fd1-80f1-2b58ceb7754a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0ODg3OTEsIm5iZiI6MTczOTQ4ODQ5MSwicGF0aCI6Ii81MTIxMTQ4LzM4OTAyMTk0Mi01NjQ3OWY4Ni03MGU4LTRmZDEtODBmMS0yYjU4Y2ViNzc1NGEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTNUMjMxNDUxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWM1MjhiNTAwMzlhYmY5MWRhZjcwZDEzMTNiN2M1MjI3OTQ4MWNiMzdjMTcyYmI4YTc0MWRiNjcxYjcwNmIxZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.Sojyn2ClAxK8h0L0UX30SkU_MdFH_184cgUB35_R1CA)
yarn webiny deploy
command, we show the following short message:While this is fine when really deploying Webiny for the first time from a local machine, in CI environments, it turns out it's best we just don't show it.
This is because the message we see above relies on the result of the internal call of the
yarn webiny output core --env xyz
, which doesn't work actually if the Core application wasn't built or deployed beforehand. Which is actually the case when runningyarn webiny deploy
, so the above message is actually incorrectly shown to the user.To quickly address this, with this PR, we just ignore showing this message when in CI.
How Has This Been Tested?
Manually.
Documentation
Changelog.