Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployments - Skip 'First Deployment" Check When In CI #4408

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

adrians5j
Copy link
Member

@adrians5j adrians5j commented Nov 22, 2024

Changes

When users deploy their project for the first time via the yarn webiny deploy command, we show the following short message:
image

While this is fine when really deploying Webiny for the first time from a local machine, in CI environments, it turns out it's best we just don't show it.

This is because the message we see above relies on the result of the internal call of the yarn webiny output core --env xyz, which doesn't work actually if the Core application wasn't built or deployed beforehand. Which is actually the case when running yarn webiny deploy, so the above message is actually incorrectly shown to the user.

To quickly address this, with this PR, we just ignore showing this message when in CI.

How Has This Been Tested?

Manually.

Documentation

Changelog.

@webiny-bot webiny-bot added this to the 5.41.2 milestone Nov 22, 2024
@adrians5j adrians5j merged commit 69a78b3 into dev Nov 25, 2024
16 checks passed
@adrians5j adrians5j deleted the adrian/skip-first-deploy-check-in-ci branch January 7, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants