-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app-headless-cms): various full screen editor #4480
Conversation
/cypress |
Cypress E2E tests have been initiated (for more information, click here). ✨ |
Cypress E2E tests have been initiated (for more information, click here). ✨ |
/cypress |
Cypress E2E tests have been initiated (for more information, click here). ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Maybe we slightly rename the flag here?
Maybe from allowCmsLegacyEntryEditor
to just cmsLegacyEntryEditor
?
IDK, don't see the point in having the "allow" verb. :)
Changes
This PR introduces a couple of fixes for the full-screen editor in the Headless CMS:
cmsLegacyEntryEditor
feature flag.ref
field with theDetailed view with modal search
renderer in a two-column layout. Refer to the screenshots for visual reference.Screenshots
How Has This Been Tested?
Manually + Cypress