Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app-headless-cms): various full screen editor #4480

Merged
merged 6 commits into from
Jan 9, 2025

Conversation

leopuleo
Copy link
Contributor

@leopuleo leopuleo commented Jan 7, 2025

Changes

This PR introduces a couple of fixes for the full-screen editor in the Headless CMS:

  1. Now, the full-screen editor is the default. Developers can disable it by using the legacy two-column setup, setting the cmsLegacyEntryEditor feature flag.
  2. The full-screen editor container has been expanded by 100px to more effectively accommodate a particular use case: the ref field with the Detailed view with modal search renderer in a two-column layout. Refer to the screenshots for visual reference.

Screenshots

CleanShot 2025-01-07 at 15 38 43@2x
CleanShot 2025-01-07 at 15 38 13@2x

How Has This Been Tested?

Manually + Cypress

@leopuleo leopuleo self-assigned this Jan 7, 2025
@webiny-bot webiny-bot added this to the 5.42.0 milestone Jan 7, 2025
@leopuleo
Copy link
Contributor Author

leopuleo commented Jan 7, 2025

/cypress

Copy link

github-actions bot commented Jan 7, 2025

Cypress E2E tests have been initiated (for more information, click here). ✨

@leopuleo leopuleo added the cms label Jan 7, 2025
Copy link

github-actions bot commented Jan 8, 2025

Cypress E2E tests have been initiated (for more information, click here). ✨

@leopuleo
Copy link
Contributor Author

leopuleo commented Jan 8, 2025

/cypress

Copy link

github-actions bot commented Jan 8, 2025

Cypress E2E tests have been initiated (for more information, click here). ✨

Copy link
Member

@adrians5j adrians5j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe we slightly rename the flag here?

Maybe from allowCmsLegacyEntryEditor to just cmsLegacyEntryEditor?

IDK, don't see the point in having the "allow" verb. :)

@leopuleo leopuleo requested a review from adrians5j January 9, 2025 11:18
@leopuleo leopuleo merged commit 6bf1d8f into next Jan 9, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants