Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply bootswatch theme #2

Open
vdtidake opened this issue Aug 22, 2013 · 4 comments
Open

Apply bootswatch theme #2

vdtidake opened this issue Aug 22, 2013 · 4 comments

Comments

@vdtidake
Copy link

Hi,
I tried to apply the spacelab theme in my web application, but it doesn't seems to be working.

If I add,
<link rel="stylesheet" href="webjars/bootstrap/3.0.0/css/bootstrap.min.css">
<link rel="stylesheet" href="webjars/bootstrap/3.0.0/css/bootstrap-theme.min.css">
<link rel="stylesheet" href="webjars/font-awesome/3.2.1/css/font-awesome.min.css">

page displays properly with the bootstrap theme but,

<link rel="stylesheet" href="webjars/bootswatch/2.3.1/spacelab/bootstrap.css" media="screen">
<link rel="stylesheet" href="webjars/bootswatch/2.3.1/css/font-awesome.min.css">
<link rel="stylesheet" href="webjars/bootswatch/2.3.1/css/bootswatch.css">

this is not working, shows very distracted UI.

Please help

@jamesward
Copy link
Member

My guess is that there is an incompatibility between these versions.

@aheritier
Copy link

at least one issue is that there is no /fonts/ directory in bootswatch archive with required bootstrap fonts (glyphicons-halflings*). But I'm not sure that the bootswatch archive provided by @thomaspark should contain it...

@aheritier
Copy link

I don't really see how to fix such webjar without repackaging it differently. From my opinion what we should do is to redo the packaging to create one webjar per theme (bootswatch-A.B.C-THEMEXXXX.jar) including only all bootstrap distribution files and an override of bootstrap(.min).css for the given them. This will give something usable as webjars and lighter as a repackaging of the distribution provided by @thomaspark isn't really useful here. I'll see if I can do a prototype but in anycase it won't be backward compatible. @jamesward do you support maven classifiers or should I create a project/artifact per theme ?

@aheritier
Copy link

Pull request #7 should solve this issue for bootstrap 3 users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants