One artifact per theme #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd we add one web jar per theme containing all bootstrap resources + theme files
|
The Pull Request #6 is solving the issue #2 for me. |
| <parent> | ||
| <artifactId>bootswatch</artifactId> | ||
| <groupId>org.webjars</groupId> | ||
| <version>3.0.3_2-SNAPSHOT</version> |
There was a problem hiding this comment.
I think we can use a variable like ${parent.version} so that we don't need to manually change all of these for a release.
There was a problem hiding this comment.
No you cannot use properties in GAV :( That's an annoying restriction of Maven to have to duplicate the verion in all POMs. You have to use the versions or release plugins to update them
|
I close this PR and I prepare a new one which is integrating all remarks we had here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add the generation of one webjar artifact per theme with all bootstrap resources correctly organized. It should solve issue #2
<script type="text/javascript" src="webjars/bootswatch-spacelab/3.0.3+1/js/bootstrap.min.js"></script>Just use something like this in your project