Implement tile #100
Merged
Implement tile #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdwr
approved these changes
Sep 4, 2024
| } | ||
| if (!repetitions.every((v) => Number.isInteger(v) && v > 0)) { | ||
| throw new Error( | ||
| `Invalid repetitions ${repetitions} - it should be an Array of positive integers.`); |
There was a problem hiding this comment.
This reminds me - I want to try adding 0-dimension support into DirectML.dll so these cases can cleanly work without checks in the Chromium DML backend or the ORT DML EP. (resolve me)
huningxin
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@huningxin @fdwr PTAL, thanks.