Implement quantizeLinear #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdwr
reviewed
Sep 5, 2024
src/quantize_linear.js
Outdated
Comment on lines
22
to
23
| const addOutput = add(div(input, scale), zeroPoint); | ||
| const roundOutput = unary(addOutput, (x) => roundToNearestEvens(x)); |
There was a problem hiding this comment.
Suggested change
| const addOutput = add(div(input, scale), zeroPoint); | |
| const roundOutput = unary(addOutput, (x) => roundToNearestEvens(x)); | |
| const dividedOutput = div(input, scale); | |
| const roundedOutput = unary(dividedOutput, (x) => roundToNearestEvens(x)); | |
| const addedOutput = add(roundedOutput, zeroPoint); |
Round before adding.
| } | ||
|
|
||
| it('quantizeLinear 1D to uint8 broadcasting scale and zeroPoint', function() { | ||
| testQuantizeLinear( |
BruceDai
force-pushed
the
implement_quantizeLinear
branch
from
f470ae0
to
2e7bfd3
Compare
BruceDai
commented
Sep 5, 2024
| } | ||
|
|
||
| it('quantizeLinear 1D to uint8 broadcasting scale and zeroPoint', function() { | ||
| testQuantizeLinear( |
src/quantize_linear.js
Outdated
Comment on lines
22
to
23
| const addOutput = add(div(input, scale), zeroPoint); | ||
| const roundOutput = unary(addOutput, (x) => roundToNearestEvens(x)); |
huningxin
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@huningxin @fdwr @lisa0314 PTAL, thanks.