Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement gelu #73

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Implement gelu #73

merged 2 commits into from
Apr 16, 2024

Conversation

BruceDai
Copy link
Contributor

@BruceDai BruceDai commented Apr 9, 2024

Fixed #72.

@fdwr @huningxin @mingmingtasd PTAL, thanks.

Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (just a name typo, else LGTM)

src/unary.js Outdated Show resolved Hide resolved
Copy link

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@huningxin huningxin merged commit c419a51 into webmachinelearning:main Apr 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement gelu
3 participants