Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using the TensorFlow.js WebGPU backend #190

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

reillyeon
Copy link
Contributor

No description provided.

@reillyeon
Copy link
Contributor Author

@huningxin, @BruceDai, @Honry, please take a look.

Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits, thanks!

common/utils.js Outdated Show resolved Hide resolved
facial_landmark_detection/index.html Outdated Show resolved Hide resolved
@reillyeon
Copy link
Contributor Author

I'm sorry, I somehow accidentally pushed this PR based on an unfinished version of this patch. I will update with the final version later.

@reillyeon
Copy link
Contributor Author

Please take another look.

Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Collaborator

@Honry Honry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! While I will suspend this PR util the webnn-polyfill enables webgpu backend. (webmachinelearning/webnn-polyfill#192)

@reillyeon
Copy link
Contributor Author

That isn't strictly necessary. I found that at least some of the demos work using the older WebGPU backend.

@Honry
Copy link
Collaborator

Honry commented Nov 14, 2023

@reillyeon, oddly, I tested most samples with current WebGPU backend (older one), no one works expectedly.
e.g.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants