Fix MLTensorUsage is undefined issue #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Polyfill MLTensorUsage to make it compatible with old version of Chrome
Honry
force-pushed
the
remove-MLTensorUsage
branch
from
be33084
to
06e90e4
Compare
|
@huningxin, @ibelem, PTAL, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromium has removed MLTensorUsage at https://chromium-review.googlesource.com/c/chromium/src/+/6015318, this would cause
the MLTensorUsage is undefinedissue in latest Chrome Canary. If we remove it directly the old version of Chrome will fail.So in the PR we polyfill the MLTensorUsage to make it compatible.