Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference newly landed WebIDL "transferable" definition #732

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

inexorabletash
Copy link
Member

@inexorabletash inexorabletash commented Jul 19, 2024

As promised, the local algorithm "detachable" migrated to WebIDL[1], so we can drop our copy of the algorithm and reference WebIDL's version instead, which is identical except for a name change[3].

(If you're building the spec locally and run into errors, force a Bikeshed update[2] to ensure you have the latest indexes.)

1: whatwg/webidl@d6927d5
2: https://speced.github.io/bikeshed/#updating-bikeshed
3: whatwg/webidl#1419 (comment)

Ref: #351


Preview | Diff

As promised, the local algorithm "detachable" migrated to WebIDL[1],
so we can drop our copy of the algorithm and reference WebIDL's
version instead, which is identical except for a name change[3].

(If you're building the spec locally and run into errors, force
a Bikeshed update[2] to ensure you have the latest indexes.)

1: whatwg/webidl@d6927d5
2: https://speced.github.io/bikeshed/#updating-bikeshed
3: whatwg/webidl#1419 (comment)

Ref: webmachinelearning#351
@inexorabletash inexorabletash requested a review from fdwr July 19, 2024 17:16
@inexorabletash
Copy link
Member Author

Easy peasy - @fdwr can you please review/merge?

@fdwr fdwr merged commit 46ba167 into webmachinelearning:main Jul 19, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Jul 19, 2024
SHA: 46ba167
Reason: push, by fdwr

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@inexorabletash inexorabletash deleted the use-idl-transferable branch July 20, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants