Skip to content

Commit

Permalink
1.4.1
Browse files Browse the repository at this point in the history
  • Loading branch information
webmandesign committed Jan 30, 2019
1 parent f9ce4b8 commit 3b79104
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 5 deletions.
12 changes: 12 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
# Reykjavik Changelog

## 1.4.1

* **Fix**: Background image URL escaping in CSS code

### Files changed:

changelog.md
readme.txt
style.css
library/includes/classes/class-css-variables.php


## 1.4.0

* **Add**: WP Subtitle plugin compatibility
Expand Down
7 changes: 4 additions & 3 deletions library/includes/classes/class-css-variables.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
* @subpackage Customize
*
* @since 1.4.0
* @version 1.4.0
* @version 1.4.1
*
* Contents:
*
Expand Down Expand Up @@ -66,7 +66,7 @@ public static function init() {
* @uses `wmhook_reykjavik_theme_options` global hook
*
* @since 1.4.0
* @version 1.4.0
* @version 1.4.1
*/
public static function get_variables_array() {

Expand Down Expand Up @@ -153,7 +153,8 @@ public static function get_variables_array() {
);
}

$css_vars[ '--' . sanitize_title( $option['id'] ) ] = esc_attr( $value );
// Do not apply `esc_attr()` as it will escape quote marks, such as in background image URL.
$css_vars[ '--' . sanitize_title( $option['id'] ) ] = $value;

/**
* Filters CSS variables output in array after each single variable processing.
Expand Down
5 changes: 4 additions & 1 deletion readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Contributors: webmandesign
Tags: one-column, two-columns, right-sidebar, grid-layout, flexible-header, accessibility-ready, custom-background, custom-colors, custom-header, custom-menu, custom-logo, editor-style, featured-image-header, featured-images, footer-widgets, full-width-template, rtl-language-support, sticky-post, theme-options, threaded-comments, translation-ready, blog, e-commerce, portfolio
Requires at least: 4.7.0
Tested up to: 5.0.3
Stable tag: 1.4.0
Stable tag: 1.4.1
License: GNU General Public License v3
License URI: https://www.gnu.org/licenses/gpl-3.0.html

Expand Down Expand Up @@ -37,6 +37,9 @@ Please see `changelog.md` file.

== Upgrade Notice ==

= 1.4.1 =
* Fixing background image URL escaping in CSS code.

= 1.4.0 =
* Using CSS variables instead of generating a customized stylesheet, improving security, improving code, improving accessibility.

Expand Down
2 changes: 1 addition & 1 deletion style.css
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Theme Name: Reykjavik
Theme URI: https://www.webmandesign.eu/portfolio/reykjavik-wordpress-theme/
Author: WebMan Design
Author URI: https://www.webmandesign.eu/
Version: 1.4.0
Version: 1.4.1
Text Domain: reykjavik
Domain Path: /languages
License: GNU General Public License v3
Expand Down

0 comments on commit 3b79104

Please sign in to comment.