Minor stuff #148
Merged
Minor stuff #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
throwaway96
force-pushed
the
minor-stuff-202307
branch
from
42dd690
to
678ebb1
Compare
The -d flag to run-js-service enables debugging, but it only works when /var/luna/preferences/devmode_enabled is a file. This patches out that check, allowing debugging of any non-system service run with this wrapper even when devmode_enabled is a directory.
Buffer.indexOf() doesn't exist in old Node.js, so read the file into a string instead. This fixes "TypeError: undefined is not a function" when calling updateStartupScript. Also return a stack trace in the Luna payload on error to aid in debugging any future issues.
This file was being read twice: once to hash it, and again for its contents. The new function hashString() is now used to compute the hash from the data already read.
throwaway96
force-pushed
the
minor-stuff-202307
branch
from
678ebb1
to
54ad059
Compare
mariotaku
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/var/luna/preferences/devmode_enabledisn't a fileupdateStartupScripton old webOS (with Node.js <=v0.12.x)start-devmode.shonce