Revert to older node-fetch to fix compatibility with old Node.js #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This format has been supported since npm 7, which was bundled with Node.js 15, and we're now building with Node.js 16.
node-fetch commit 50536d1 broke compatibility with Node.js <3.2.0 by using emitter.listenerCount().
mariotaku
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-fetch2.6.8 started usingemitter.listenerCount()(see node-fetch/node-fetch@50536d1), which was introduced in Node.js v3.2.0. This causes the service to crash on old webOS (e.g., webOS 3.0, which uses v0.12.2).Also, since we're now building with Node.js v16, we can use
lockfileVersion3 (supported since npm 7/Node.js v15). We should probably move to v18, as it's the current LTS release and v16 is no longer supported. As demonstrated by this issue, trying to use old, unsupported Node.js releases with modern software is a fool's errand.