Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous cleanup #177

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Conversation

throwaway96
Copy link
Member

  • Removed .prettierrc. Settings were mostly moved to .editorconfig, but one ended up in eslint.config.mjs. Prettier still takes them into account.
  • Tweaked some ESLint and EditorConfig settings. The JS settings in .editorconfig now cover TS files and additional JS extensions.
  • Removed a few unnecessary ESLint disable comments. I used reportUnusedDisableDirectives, but I mostly left anything that would be relevant if the associated rule were enabled. The ones I removed were along the lines of no-unused-vars on a line with no variables.
  • Modified a type to eliminate a suppressed TypeScript error in adapter.ts.
  • Fixed a handful of spelling mistakes.
  • Replaced tabs being used for indentation with spaces. The entire repo is now consistently indented with spaces. I also removed extraneous whitespace at the end of a few lines.

I don't think any of this will really affect the code that ends up in the IPK.

@mangaz3n

This comment was marked as spam.

@throwaway96
Copy link
Member Author

ty do you have code to replace my code and take away users made it?

Stop. You didn't respond in RootMyTV/RootMyTV.github.io#141 with any evidence or even basic information about your TV, so nobody is inclined to take you seriously. Spamming our other repos is not going to help with that. The opposite, in fact.

Copy link
Member

@kitsuned kitsuned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@throwaway96 throwaway96 merged commit f19064a into webosbrew:main Mar 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants