Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: stringify loader object - fixes #95 #206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peter-spireng
Copy link
Contributor

At first moment we need agree on API and stringfy result. So, can you please review tests and if they are right, I can add real implementation.

@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #206 (b140c4e) into master (9fe2381) will increase coverage by 0.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
+ Coverage   76.66%   77.17%   +0.50%     
==========================================
  Files          10       11       +1     
  Lines         360      368       +8     
  Branches      112      114       +2     
==========================================
+ Hits          276      284       +8     
  Misses         73       73              
  Partials       11       11              
Impacted Files Coverage Δ
lib/index.js 100.00% <100.00%> (ø)
lib/stringifyUseEntries.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe2381...b140c4e. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need it here, you can implement this on loader side

@peter-spireng
Copy link
Contributor Author

Issue #95 is still open with "Help wanted" label, so I thought it is still valid feature request ...

@alexander-akait
Copy link
Member

We should avoid adding new methods here, if we really need it, we should implement it on webpack side (but I don't think we really need it). We want to deprecated it on the next major release.

And yes, we need to close issues...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants