custom fetch: always use if defined (#86)

* custom fetch: if custom fetch is a function, always use it (to support simpler cdp bindings instead of puppeteer specific return behavior) bump to 0.7.1
webrecorder · Feb 21, 2025 · 7fb29fe · 7fb29fe
1 parent 43b967d
commit 7fb29fe
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/dist/behaviors.js b/dist/behaviors.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "browsertrix-behaviors",
-  "version": "0.7.0",
+  "version": "0.7.1",
   "main": "index.js",
   "author": "Webrecorder Software",
   "license": "AGPL-3.0-or-later",

diff --git a/src/autofetcher.ts b/src/autofetcher.ts
@@ -167,13 +167,9 @@ export class AutoFetcher extends BackgroundBehavior {
 
         this.numPending++;
 
-        let success = false;
-
-        if ((self as any).__bx_fetch) {
-          success = await (self as any).__bx_fetch(url);
-        }
-
-        if (!success) {
+        if (typeof((self as any).__bx_fetch) === "function") {
+          await (self as any).__bx_fetch(url);
+        } else {
           await this.doFetchNonCors(url);
         }