instead of puppeteer.exposeFunction(), use cdp function bindings directly to avoid issues custom toJSON overrides: #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ikreymer
commented
Feb 21, 2025
ikreymer
commented
- add Runtime.addBinding for each exposed function, handle in one place with Runtime.bindingCalled
- convert binding names to BxFunctionBindings enum
- update to browsertrix-behaviors 0.7.1 to avoid waiting for return value
- fixes "Invalid Page - not a valid URL" on particular website #770
…ctly to avoid issues custom toJSON overrides: - add Runtime.addBinding for each exposed function, handle in one place with Runtime.bindingCalled - convert binding names to BxFunctionBindings enum - update to browsertrix-behaviors 0.7.1 to avoid waiting for return value - fixes #770
tw4l
reviewed
Feb 26, 2025
There was a problem hiding this comment.
This all looks good to me, but in testing it seems that the autoclick behavior might not be working as expected on this branch?
This is the command I'm trying:
docker compose run crawler crawl --url https://www.bs.ch/themen --generateWACZ --scopeType prefix --limit 10 --behaviors autoclick --collection autoclick-testOff of latest main, replay for this site works as expected (should be able to click the "Arbeit und Steuern" link and have a new page load instead of a generic 500 error). Off this branch it does not. Behavior logging looks identical between the two branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.