Fixed code by Clippy lints

webrtc-rs · Mar 28, 2024 · e8d498a · e8d498a
1 parent d690c46
commit e8d498a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/interceptor/src/twcc/twcc_test.rs b/interceptor/src/twcc/twcc_test.rs
@@ -259,7 +259,7 @@ fn test_feedback() -> Result<()> {
             pkt.packet_chunks
         );
 
-        let expected_deltas = vec![
+        let expected_deltas = [
             RecvDelta {
                 type_tcc_packet: SymbolTypeTcc::PacketReceivedSmallDelta,
                 delta: 0,
@@ -338,7 +338,7 @@ fn test_feedback() -> Result<()> {
             pkt.packet_chunks
         );
 
-        let expected_deltas = vec![
+        let expected_deltas = [
             RecvDelta {
                 type_tcc_packet: SymbolTypeTcc::PacketReceivedSmallDelta,
                 delta: 0,

diff --git a/webrtc/src/rtp_transceiver/mod.rs b/webrtc/src/rtp_transceiver/mod.rs
@@ -301,7 +301,7 @@ impl RTCRtpTransceiver {
 
     /// mid gets the Transceiver's mid value. When not already set, this value will be set in CreateOffer or create_answer.
     pub fn mid(&self) -> Option<SmolStr> {
-        self.mid.get().map(Clone::clone)
+        self.mid.get().cloned()
     }
 
     /// kind returns RTPTransceiver's kind.

diff --git a/webrtc/src/rtp_transceiver/rtp_receiver/mod.rs b/webrtc/src/rtp_transceiver/rtp_receiver/mod.rs
@@ -493,6 +493,8 @@ impl RTCRtpReceiver {
         if tracks.len() != 1 {
             None
         } else {
+            // Clippy bug (reported at https://github.com/rust-lang/rust-clippy/issues/12560) suggests .first().cloned()
+            #[allow(clippy::map_clone)]
             tracks.first().map(|t| Arc::clone(&t.track))
         }
     }