Implement pion commit 2184 - mux: drop packets when buffer is full #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #516 +/- ##
=======================================
Coverage 61.52% 61.53%
=======================================
Files 529 529
Lines 48866 48878 +12
Branches 12375 12381 +6
=======================================
+ Hits 30067 30079 +12
+ Misses 9593 9591 -2
- Partials 9206 9208 +2 ☔ View full report in Codecov by Sentry. |
stuqdog
commented
Nov 21, 2023
Comment on lines
1994
to
2005
| log::debug!("s.read_sctp begin"); | ||
| match s0.read_sctp(&mut buf).await { | ||
| Ok((0, PayloadProtocolIdentifier::Unknown)) => { | ||
| log::debug!("s0.read_sctp EOF"); | ||
| let _ = done_ch_tx0.send(Some(Error::ErrEof)).await; | ||
| } | ||
| Ok(_) => { | ||
| panic!("must be error"); | ||
| } | ||
| Err(err) => { | ||
| log::debug!("s0.read_sctp err {:?}", err); | ||
| let _ = done_ch_tx0.send(Some(err)).await; |
There was a problem hiding this comment.
(flyby) clippy was complaining that this loop never actually looped, so I removed it.
rainliu
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements pion commit 2184.
Currently it's assumed that the read buffer will never fill, and so any failure to
writeshould be cause to return anErr. This isn't always true however, particularly in high load scenarios. Perpionfixes, we should instead log and drop packets when the buffer is full, and continue to return an error in other failure cases.See pion/webrtc#2152 and pion/webrtc#2180 for more details.