fix understated ipnet version requirement
#521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`webrtc-util` uses `IpNet::with_netmask`, which was introduced in version 2.6.0. If someone is using a `Cargo.lock` with an older version of `ipnet`, they'll get a compile error when introducing `webrtc-util` (or upgrading it to after this call was added). Adding the correct version requirement in `Cargo.toml` forces the upgrade to fix this.
yngrtc
approved these changes
Dec 30, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #521 +/- ##
=======================================
Coverage 61.52% 61.53%
=======================================
Files 529 529
Lines 48855 48859 +4
Branches 12369 12381 +12
=======================================
+ Hits 30060 30063 +3
+ Misses 9589 9587 -2
- Partials 9206 9209 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webrtc-utilusesIpNet::with_netmask, which was introduced in version 2.6.0. If someone is using aCargo.lockwith an older version ofipnet, they'll get a compile error when introducingwebrtc-util(or upgrading it to after this call was added). Adding the correct version requirement inCargo.tomlforces the upgrade to fix this.