Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broaden compatibility for embedded platforms #536

Closed
wants to merge 3 commits into from

Conversation

coder0xff
Copy link
Contributor

I'm working on compiling WebRTC on the Xtensa (ESP32s3) platform.

  • Tokio was recently updated to support more platforms, but certain features are not available (and may never be). The "process" and "signal" features aren't used by WebRTC. Rather than use the "full" feature group, the relevant Cargo.toml's have been updated to list the set of features included in "full", excluding the "process" and "signal" features. WebRTC builds correctly against tokio with these changes.
  • Migrates to the portable-atomic library from std::sync::atomic to support more platforms

@coder0xff coder0xff changed the title Broaden Compatibility for Embedded Platforms Broaden compatibility for embedded platforms Feb 19, 2024
@rainliu
Copy link
Member

rainliu commented Feb 20, 2024

please make sure all checks are passed. Thanks.

@coder0xff
Copy link
Contributor Author

please make sure all checks are passed. Thanks.

I got cargo test passing and pushed, but the checks are now cleared so I can't see if any more failed. (I'm not familiar with GitHub's checks system.) Hopefully everything is good anyway.

@marcbrevoort-cyberhive
Copy link

I'd love to see this go in, if everything is okay with it. If not, it would be useful to know what's stopping it.

@coder0xff
Copy link
Contributor Author

I'm rolling back the master branch on my fork so I can try the actions merging into my own master first. I'll close this PR in the meantime and re-open it once I can get past that step.

@coder0xff coder0xff closed this Mar 13, 2024
@coder0xff
Copy link
Contributor Author

I had to create a new PR after rebasing. #546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants