Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code improvement, part 1: modules documentation #549

Merged
merged 5 commits into from
Mar 30, 2024

Conversation

ProgramCrafter
Copy link
Contributor

In particular, several doc-links which pointed nowhere were fixed. This code should also pass Clippy's and rustfmt's judgement.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 61.68%. Comparing base (cc7e2ba) to head (e8d498a).

Files Patch % Lines
webrtc/src/peer_connection/sdp/sdp_test.rs 61.11% 0 Missing and 7 partials ⚠️
webrtc/src/ice_transport/ice_candidate.rs 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #549      +/-   ##
==========================================
- Coverage   61.70%   61.68%   -0.03%     
==========================================
  Files         529      529              
  Lines       48870    48828      -42     
  Branches    12273    12250      -23     
==========================================
- Hits        30157    30119      -38     
+ Misses       9580     9548      -32     
- Partials     9133     9161      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ProgramCrafter
Copy link
Contributor Author

Those four lints failing Clippy check are fixed! Or, more precisely, one lint was incorrect so it was locally-allowed.

@rainliu rainliu merged commit a97d49e into webrtc-rs:master Mar 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants