Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix OBS-studio DTLS failed #557

Merged
merged 1 commit into from
Apr 20, 2024
Merged

fix OBS-studio DTLS failed #557

merged 1 commit into from
Apr 20, 2024

Conversation

a-wing
Copy link
Contributor

@a-wing a-wing commented Apr 19, 2024

We found use OBS-studio WHIP cannot PeerConnected

package DTLS have problem

We found after this commit have this bug

This PR #496 and this commit after 935283a

Finally we found the problem. But, I'm not sure this have bug

https://github.com/RustCrypto/utils/blob/master/block-padding/src/lib.rs#L176-L216

Maybe, webrtc-rs is using this library incorrectly

binbat/live777#39
binbat/live777#58

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.70%. Comparing base (a97d49e) to head (6ae4033).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
- Coverage   61.76%   61.70%   -0.07%     
==========================================
  Files         529      530       +1     
  Lines       48828    48848      +20     
  Branches    12250    12274      +24     
==========================================
- Hits        30161    30141      -20     
- Misses       9532     9544      +12     
- Partials     9135     9163      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yngrtc
Copy link
Collaborator

yngrtc commented Apr 19, 2024

please fix formatting

@yngrtc yngrtc merged commit 4e09f92 into webrtc-rs:master Apr 20, 2024
5 checks passed
@edaniels
Copy link

edaniels commented May 1, 2024

@rainliu, can you comment on why 935283a changed the padding in the first place? I'm not sure I understand the reasoning and this was particularly hard to track down. Thank you!

@rainliu
Copy link
Member

rainliu commented May 2, 2024

dtls dependent crates upgrade to new version, however, incorrect usage of new APIs of those crates causes incompatible PADDING.

aes = "0.8"
cbc = { version = "0.1", features = [ "block-padding", "alloc"] }
ccm = "0.5"

@edaniels
Copy link

edaniels commented May 2, 2024

I see, but how is PKCS7 relevant to DTLS? Does the RFC say somewhere that the padding schemes are equivalent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants