Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the new feature of the crc crate for more throughput in sctp #569

Merged
merged 2 commits into from
May 18, 2024
Merged

use the new feature of the crc crate for more throughput in sctp #569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5182d2
use the new feature of the crc crate for more throughput in sctp
May 15, 2024
14f02f5
changelog entry
May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sctp/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Unreleased

* Use the new algorithm in crc crate for better throughput [#569](https://github.com/webrtc-rs/webrtc/pull/569)

## v0.8.0

* Fix 'attempt to add with overflow' panic in dev profile [#393](https://github.com/webrtc-rs/webrtc/pull/393)
Expand Down
2 changes: 1 addition & 1 deletion sctp/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ tokio = { version = "1.32.0", features = [
] }
bytes = "1"
rand = "0.8"
crc = "3"
crc = "3.2.1"
async-trait = "0.1"
log = "0.4"
thiserror = "1"
Expand Down
4 changes: 2 additions & 2 deletions sctp/src/util.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use bytes::Bytes;
use crc::{Crc, CRC_32_ISCSI};
use crc::{Crc, CRC_32_ISCSI, Table};

pub(crate) const PADDING_MULTIPLE: usize = 4;

Expand All @@ -11,7 +11,7 @@ pub(crate) fn get_padding_size(len: usize) -> usize {
/// We need to use it for the checksum and don't want to allocate/clear each time.
pub(crate) static FOUR_ZEROES: Bytes = Bytes::from_static(&[0, 0, 0, 0]);

pub(crate) const ISCSI_CRC: Crc<u32> = Crc::<u32>::new(&CRC_32_ISCSI);
pub(crate) const ISCSI_CRC: Crc<u32, Table<16>> = Crc::<u32, Table<16>>::new(&CRC_32_ISCSI);

/// Fastest way to do a crc32 without allocating.
pub(crate) fn generate_packet_checksum(raw: &Bytes) -> u32 {
Expand Down
Loading