Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of Criterion bench groups #590

Merged
merged 8 commits into from
Jun 30, 2024

Conversation

Serial-ATA
Copy link
Contributor

  • Cleaned up the benchmark IDs by removing the "Benchmark" prefix and using snake_case for the method names
  • Split the benchmarks into groups based on the crate for easier recognition

For example, BenchmarkLifetime/AddTo is now TURN/Lifetime/add_to.

To make things easier to CTRL-F from Pion, I left the original Go-style names in comments above the benchmarks.

How the index looked before:

old

How it looks now:

new

Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.36%. Comparing base (a74b96d) to head (77797b2).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #590      +/-   ##
==========================================
- Coverage   61.38%   61.36%   -0.02%     
==========================================
  Files         533      532       -1     
  Lines       49711    49719       +8     
  Branches    12628    12620       -8     
==========================================
- Hits        30513    30508       -5     
- Misses       9856     9868      +12     
- Partials     9342     9343       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rainliu rainliu merged commit 19004ef into webrtc-rs:master Jun 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants