Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: Add support for unordered unreliable data channels #609

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

PaulOlteanu
Copy link
Contributor

@PaulOlteanu PaulOlteanu changed the title data: Add support for unordered unreliable data channels webrtc: Add support for unordered unreliable data channels Sep 4, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 62.16216% with 28 lines in your changes missing coverage. Please review.

Project coverage is 60.61%. Comparing base (23bbc1f) to head (ebbf745).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
webrtc/src/data_channel/data_channel_test.rs 61.11% 2 Missing and 26 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #609      +/-   ##
==========================================
+ Coverage   60.59%   60.61%   +0.02%     
==========================================
  Files         482      471      -11     
  Lines       47981    48239     +258     
  Branches    12478    12537      +59     
==========================================
+ Hits        29075    29242     +167     
- Misses       9665     9674       +9     
- Partials     9241     9323      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

webrtc/src/data_channel/mod.rs Outdated Show resolved Hide resolved
} else {
channel_type = ChannelType::PartialReliableTimedUnordered;

(None, Some(max_packet_lifetime)) => {
Copy link
Member

@rainliu rainliu Sep 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this line to

_ => {

otherwise, compile error due to missing one case handling

Copy link
Contributor Author

@PaulOlteanu PaulOlteanu Sep 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the cases are covered (and I compiled and ran tests locally fine). The CI failures don't seem related to my changes

@rainliu rainliu merged commit 8d95518 into webrtc-rs:master Sep 7, 2024
4 of 5 checks passed
tubzby pushed a commit to tubzby/webrtc-rs that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Making an unordered unreliable datachannel doesn't seem possible
2 participants