-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webrtc: Add support for unordered unreliable data channels #609
Conversation
f99b38b
to
3f27126
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #609 +/- ##
==========================================
+ Coverage 60.59% 60.61% +0.02%
==========================================
Files 482 471 -11
Lines 47981 48239 +258
Branches 12478 12537 +59
==========================================
+ Hits 29075 29242 +167
- Misses 9665 9674 +9
- Partials 9241 9323 +82 ☔ View full report in Codecov by Sentry. |
3f27126
to
ebbf745
Compare
} else { | ||
channel_type = ChannelType::PartialReliableTimedUnordered; | ||
|
||
(None, Some(max_packet_lifetime)) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change this line to
_ => {
otherwise, compile error due to missing one case handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the cases are covered (and I compiled and ran tests locally fine). The CI failures don't seem related to my changes
Fixes #371. Most of the change is in
RTCDataChannel::open
to match https://github.com/pion/webrtc/blob/4ef00e6e5f78647305cdd08568d16f49ae6190eb/datachannel.go#L130-L152