Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental: View Animations support #4817

Merged
merged 16 commits into from
Feb 4, 2025
Merged

experimental: View Animations support #4817

merged 16 commits into from
Feb 4, 2025

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Feb 1, 2025

Description

ref #2645

  • - Add view-timeline-name and scroll-timeline-name support, and prefixer (use custom property for unsupported browsers)
  • - Add initial story

Steps for reproduction

https://6382151c8b47d4399fb9fc69-uljkhwtbmc.chromatic.com/iframe.html?args=&globals=&id=sdk-components-animation-view-animations--in-out&viewMode=story

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov requested a review from TrySound February 3, 2025 18:14
@istarkov istarkov marked this pull request as ready for review February 3, 2025 18:14
@istarkov istarkov changed the title experimental: View scroll support experimental: View Animations support Feb 3, 2025
@istarkov istarkov merged commit 3c42f8c into main Feb 4, 2025
17 checks passed
@istarkov istarkov deleted the view branch February 4, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants