Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental: Advanced style panel mode #4840

Merged
merged 5 commits into from
Feb 6, 2025
Merged

experimental: Advanced style panel mode #4840

merged 5 commits into from
Feb 6, 2025

Conversation

kof
Copy link
Member

@kof kof commented Feb 6, 2025

#4816

Description

  • added switch
  • full-size advaned panel

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested review from TrySound and johnsicili February 6, 2025 09:55
@TrySound
Copy link
Member

TrySound commented Feb 6, 2025

Advanced mode should show all styles, we have "listed something" flag about it in each style declaration.

@kof
Copy link
Member Author

kof commented Feb 6, 2025

Advanced mode should show all styles, we have "listed something" flag about it in each style declaration.

Yes, coming up next

@kof
Copy link
Member Author

kof commented Feb 6, 2025

Added now

@kof kof changed the title feat: advanced mode feat: Advanced style panel mode Feb 6, 2025
@kof kof changed the title feat: Advanced style panel mode experimental: Advanced style panel mode Feb 6, 2025
@kof kof merged commit 8aaa48e into main Feb 6, 2025
17 checks passed
@kof kof deleted the advaced branch February 6, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants