Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improved UX for adding multiple advanced style panel properties #4846

Merged
merged 19 commits into from
Feb 9, 2025

Conversation

kof
Copy link
Member

@kof kof commented Feb 8, 2025

#4816

Description

  • recent proeprties section
  • enter or tab in the last value in recent to show adding input again
  • close new adding property input on ESC
  • show in recent when user ads an existing property
  • handle multiple properties insertion

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested review from TrySound and johnsicili February 8, 2025 13:01
@kof kof marked this pull request as ready for review February 8, 2025 13:01
@johnsicili
Copy link
Contributor

Nice UI! Here's some feedback:

This is hard to read because values are either same line or next line and everything is same color, weight, and spacing.

Screenshot 2025-02-08 at 8 59 04 AM

Minor but these two touch

Screenshot 2025-02-08 at 9 02 07 AM

Clicking plus when add field is already there doesn't do anything. Maybe focus it
Screenshot 2025-02-08 at 9 06 12 AM

Pasting CSS puts them below the separator. Reason for this?

Screenshot 2025-02-08 at 9 07 48 AM

@kof kof changed the title experimental: Adding multiple advanced style panel properties experimental: Improved UX for adding multiple advanced style panel properties Feb 8, 2025
@kof kof changed the title experimental: Improved UX for adding multiple advanced style panel properties feat: Improved UX for adding multiple advanced style panel properties Feb 8, 2025
@kof
Copy link
Member Author

kof commented Feb 8, 2025

This is hard to read because values are either same line or next line and everything is same color, weight, and spacing.

Any ideas how to improve? Can't use blue color as its now matching defined styles from the current style source

@kof
Copy link
Member Author

kof commented Feb 8, 2025

Ok fixed everything you mentioned except of colors of properties. No idea for now what to do with that.

@johnsicili
Copy link
Contributor

It doesn't appear "enter" is working. Only when I select the property via a mouse click does it insert

enter.mp4

@kof
Copy link
Member Author

kof commented Feb 9, 2025

@johnsicili fixed

@kof kof merged commit 1c08434 into main Feb 9, 2025
17 checks passed
@kof kof deleted the advanced-multi branch February 9, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants