-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add wechaty/user/images.go #2
Conversation
Signed-off-by: dingdayu <[email protected]>
When cross-language, different languages have different package management styles and object-oriented packaging methods, such as GO, I am not sure where to get these instructions. |
@huan I need you help me. |
Hello @dingdayu ! It's great to see your Pull Request with the very first translation to the Go Wechaty (#1), your Cloud you please move those two directories ( We can merge this PR after you followed the Wechaty directory structure. Thank you very much for your interest in the Go Wechaty project, and I'm looking forward to seeing more progress from the Go community for using Wechaty! BTW: About the Go Styles
|
Signed-off-by: dingdayu <[email protected]>
Although I don't really recommend this, it does not go against anything. |
Great to see that you have followed the directory structure, good work. Let's merge this PR for making our first step on lang Go! Cheers! 🍻 |
I have invited you to join the Wechaty Contributor team on GitHub, please accept it.
And I noticed that you said "I don't really recommend this", could you please explain it in detail? We can iterate the codebase and our styles in the later commits, as we can keep learning from the community. |
This is not forbidden, But not best practice. Go recommends putting the code directly in the outer directory. We usually learn from good projects. as kubernetes,coredns. The most direct manifestation: import (
"fmt"
"github.com/wechaty/go-wechaty/src/wechaty"
) Excessive directory hierarchy on the import path, Of course, this is controversial in the community, but Go project generally doesn't have src. |
Ok, I learned that, thanks. It seems that it's not a big deal, so let's keep the whole Wechaty project aligned first, and we can adjust it when we publish Go Wechaty officially (after ding-dong-bot works). |
Hi, my name is dingdayu.
I'm not very clear about the specifications of the project, such as the title format of the PR, and how to explain the newly added incomplete other interfaces or classes, but luckily this description can be modified.