Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/better eslint rules #21

Conversation

anasnadeemws
Copy link
Collaborator

@anasnadeemws anasnadeemws commented Mar 18, 2024

This pr contains more better and stricter eslint rules.
Reference for this PR: wednesday-solutions/react-template#193

@anasnadeemws anasnadeemws changed the title Feat/better eslint rules [In progress] Feat/better eslint rules Mar 19, 2024
pages/index.js Outdated
@@ -2,6 +2,10 @@ import PropTypes from 'prop-types';
import Repos from '@app/containers/Repos/index';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove the redundant index

import Repos from '@app/containers/Repos';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make similar changes in other places where applicable as well please

@alichherawalla
Copy link
Contributor

LGTM

Copy link

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟢 Statements 90.25% 287/318
🟡 Branches 83.56% 122/146
🟡 Functions 84.82% 95/112
🟢 Lines 96.24% 588/611

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from a3ee97e

@alichherawalla alichherawalla merged commit c696228 into wednesday-solutions:master Mar 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants