Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summarize bbs regions by year #120

Closed
wants to merge 1 commit into from
Closed

Summarize bbs regions by year #120

wants to merge 1 commit into from

Conversation

gmyenni
Copy link
Contributor

@gmyenni gmyenni commented Apr 26, 2019

Use bcr the 'bird conservation region' to group routes.
Summarize by year

@codecov-io
Copy link

codecov-io commented Apr 26, 2019

Codecov Report

Merging #120 into master will decrease coverage by 1.76%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
- Coverage   70.49%   68.72%   -1.77%     
==========================================
  Files          13       13              
  Lines         505      518      +13     
==========================================
  Hits          356      356              
- Misses        149      162      +13
Impacted Files Coverage Δ
R/get_retriever_data.R 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d32a93...512846c. Read the comment docs.

@gmyenni gmyenni requested review from ha0ye and diazrenata April 26, 2019 18:22
Copy link
Member

@ha0ye ha0ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @diazrenata is focusing on trying to get the BBS data in order for analysis, and may be checking against BBS pre-processing from elsewhere, but I have a few quick notes:

  • why is the default end_yr = 2017? Is this because of the delay in getting newer BBS data processed and/or getting it into retriever?

@gmyenni
Copy link
Contributor Author

gmyenni commented May 7, 2019

  • why is the default end_yr = 2017? Is this because of the delay in getting newer BBS data processed and/or getting it into retriever?

No, it doesn't really need to be. There isn't 2018 data yet, but it won't fail even if end_yr = 2019.

@diazrenata
Copy link
Member

I've been looking into using scripts from https://github.com/weecology/bbs-forecasting/blob/master/R/forecast-bbs-core.R as a starting point for BBS data. I'm pretty new to BBS, so, my thoughts come with that qualification.

There are a couple of points of difference that might or might not be important(?) -

  • Summarizing by "conservation region" vs. route. Do we consider routes analogous to plots, and conservation regions the right scale for a "community"? Naively I would have guessed that routes are more community-scale? Happy to investigate this more but I'm sure @gmyenni, @ethanwhite have a better sense of this atm.
  • The scripts in the forecasting repo have some cleaning steps that, naively, seem like a good idea. (Removing poorly-sampled species, combining subspecies into the common species, etc). Any objection to porting those over?

@ethanwhite
Copy link
Member

I think it's a great idea to start with those functions.

Summarizing by "conservation region" vs. route. Do we consider routes analogous to plots, and conservation regions the right scale for a "community"? Naively I would have guessed that routes are more community-scale?

You're right. Routes are typically considered community scale. BCR is closer to biome.

The scripts in the forecasting repo have some cleaning steps that, naively, seem like a good idea. (Removing poorly-sampled species, combining subspecies into the common species, etc). Any objection to porting those over?

Those are fairly standard steps with BBS data (we've used them in everything BBS for over a decade) so I'm definitely 👍 on including them.

@diazrenata
Copy link
Member

#124 I added the cleaning functions from bbs-forecasting and added an argument to subset by route.

I added the region & route information as columns in covariates.

(I think the next step is to do some kind of wrapper to run All the Data for All the Routes through.)

@gmyenni
Copy link
Contributor Author

gmyenni commented May 10, 2019

Yeah, I started from https://github.com/weecology/bbs-forecasting. I just removed the stuff that I thought LDATS doesn't do. But @diazrenata obviously you know how LDATS works better than I, so I can leave this to you from now on.

I thought we would want to reduce the number of BBS communities in the data, by treating routes as subsamples within a larger region. But LDATS can't handle multiple time series within a dataset, right? So if that functionality isn't going to be added any time soon, we can just leave it at the route level and not worry about it.

@diazrenata
Copy link
Member

Thanks! I agree, for now at least, route level is the way to go. I don't think LDATS can use the grouping-by-region information yet.

@gmyenni gmyenni closed this May 10, 2019
@ha0ye ha0ye deleted the bbs branch July 11, 2019 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants