Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process ATL11 Zarr data up to 20210421 (Sourcery refactored) #296

Closed

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Jun 26, 2021

Pull Request #295 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the update/atl11_20210421 branch, then run:

git fetch origin sourcery/update/atl11_20210421
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from weiji14 June 26, 2021 11:05
dates: set = set(url.split("/")[-2] for url in urlpaths)
dates: set = {url.split("/")[-2] for url in urlpaths}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 60-84 refactored with the following changes:

if not ("No such file" in str(e)):
if "No such file" not in str(e):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function get_credentials refactored with the following changes:

  • Simplify logical expression using De Morgan identities (de-morgan)

@sourcery-ai
Copy link
Author

sourcery-ai bot commented Jun 26, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.52%.

Quality metrics Before After Change
Complexity 17.23 🙂 16.82 🙂 -0.41 👍
Method Length 220.25 ⛔ 218.75 ⛔ -1.50 👍
Working memory 15.26 ⛔ 15.19 ⛔ -0.07 👍
Quality 32.37% 😞 32.89% 😞 0.52% 👍
Other metrics Before After Change
Lines 280 276 -4
Changed files Quality Before Quality After Quality Change
atl06_to_atl11.py 32.37% 😞 32.89% 😞 0.52% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@weiji14 weiji14 closed this Jun 26, 2021
@weiji14 weiji14 deleted the sourcery/update/atl11_20210421 branch June 26, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant