Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking(CSI-314): remove legacy volume support #435

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

sergeyberezansky
Copy link
Collaborator

@sergeyberezansky sergeyberezansky commented Jan 28, 2025

TL;DR

Removed support for legacy volumes (without binding to REST API client). This change is breaking.

What changed?

  • Removed XATTR implementation of volume capacity tracking
  • Removed support for volumes not having API client bound
  • Removed "dev mode" support to run CSI sanity without actual mount of Weka filesystem (incomplete)
  • Removed tests that were run on emulated weka filesystem locally. Instead, only NFS-based CSI sanity is performed.

How to test?

  1. Deploy CSI driver with and without NFS enabled
  2. Perform NFS functional regression testing

Why make this change?

The previous implementation had performed NFS client group registration attempt on each mount, causing lots of additional API calls and reducing overall performance of volume provisioning and publishing. This change breaks the process into 2 parts, while client registration is performed during API client initialization, while only the NFS permission is ensured during mount.

@graphite-app graphite-app bot requested a review from tigrawap January 28, 2025 09:28
Copy link

graphite-app bot commented Jan 28, 2025

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (01/28/25)

1 reviewer was added to this PR based on Sergey Berezansky's automation.

@sergeyberezansky sergeyberezansky force-pushed the sergey/remove-legacy-volumes branch from 35309fd to 73c0365 Compare January 28, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant