Pack arm64 libs into linux package + x86_64/arm64 linux libs into OSX package #3
Conversation
yanok
force-pushed
the
yanok/linux-libs-on-mac
branch
from
1393c53 to
5024127
Compare
yanok
force-pushed
the
yanok/linux-libs-on-mac
branch
2 times, most recently
from
97ae6d7 to
15a5f1c
Compare
|
@JohanEngelen PTAL, it seems to be working, CI is failing because there is no osx-arm64-withAsserts version of LLVM pre-packaged. |
yanok
force-pushed
the
yanok/linux-libs-on-mac
branch
from
15a5f1c to
bb66181
Compare
And add corresponding config sections. This enables prebuilt OS X compiler to be useful for local agent build.
yanok
force-pushed
the
yanok/linux-libs-on-mac
branch
from
bb66181 to
1a4f0b0
Compare
|
Only tagged commits with |
| { | ||
| switches = [ | ||
| \"-defaultlib=phobos2-ldc,druntime-ldc\", | ||
| \"--mcpu=neoverse-n1\", |
There was a problem hiding this comment.
is setting the CPU really needed? (seems better to keep the runtime build more general as it probably won't really matter whether it uses newer CPU instructions or not)
There was a problem hiding this comment.
But that's not for the runtime build, that's the default flags to use then building for ARM64. Since Weka requires these settings and this is a Weka-specific compiler package, I thought it makes sense to add them to the config.
But of course one could argue that we should keep these settings in the Wekapp repo internally.
I'm fine both ways. I think it only matters if we want to try merging these changes upstream. If it's going to stay Weka-specific, seems to better keep the required flags in the config.
|
LGTM. Think about the CPU thing, and hit squash+merge! You can download the build package here: https://github.com/weka/ldc/actions/runs/12965886228?pr=3, so you can test locally if it's working correctly. |
Thanks! I did test cross compiling from arm64 Mac to arm64 linux. That works great. I don't see the merge button, I guess I don't have that permission :) |
No description provided.