-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WELD-2771 Revisit Weld examples, update deps, verify they work #2958
Conversation
The failures are related to update of some dependencies which have min. JDK version set to 17 |
…d into platform TCKs. Update CI to skip servlet tests for JDK 11 (some deps require 17 as min version).
I've adjusted the CI in the following way:
|
The last thing needed in this PR is testing the examples (running their tests) - I'll give it a spin next week to see if we can get at least some simple setup running. |
I've added CI setup that performs a Maven build on examples and then starts WFLY as background process, deploys JSF numberguess and runs tests against it. This should give us at least basic level of confidence. |
Examples are very outdated and don't even work with latest JDKs.
We should pick some minimal set of examples that demonstrate - EE usage, servlet usage, SE usage (, maybe the Groovy SE example?).
This can be done by keeping the Numberguess example for both, SE and JSF variants.
Things to do:
Remove JSF login and translator examplesRemove mentions of the above in our docsAdd a link to WFLY quickstarts as a source of more examples; many of them use CDI anywayUpdate JSF Numberguess to work with WFLY, Tomcat and Jetty, update its READMEUpdate test setup of JSF Numberguess to strip away Arq.Copied over from the same example under WFLY - kept some basic assertions against running deployed applicationUpdate and test SE Numberguess sampleUpdate and test SE Groovy exampleScan Weld docs for any other mention of example usage to make sure we don't have leftoversThink if and how we can test this in CIWe can surely test a build but deployments might be tricky - each setup requires starting and stopping a container