-
Notifications
You must be signed in to change notification settings - Fork 3
Install bdcs.rpm from Copr instead of pulling it from S3 #31
Conversation
The original error reported is weldr/bdcs#143 which however doesn't seem to be a problem for Jenkins. The current failure is: where this file is a symlink to /etc/alternatives/ so I'm not quire certain that is going on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok. Note that we're going to start using the new compose code in bdcs-api soon, so don't worry about export.
"Unable to add /usr/lib64/libnssckbi.so, file already added at this location" @wgwoods ^^^ this one sounds related to your work on /etc/alternatives, indeed this file is a symlink to /etc/alternatives. How do you propose I deal with this failure:
|
(Paraphrasing what I said on IRC, for the record) In the long term: we're going to have to get everyone who's using In the near-term I think we're gonna need a couple of things:
This is a specific case of a general problem - "how do we handle files that need to be generated at export-time?" - and it's gonna take some time to design a sensible long-term solution. Alas, I'd hoped this day wouldn't come so soon... |
Note: if this fails we have to merge it after #33 so we don't have to adjust the recipes inside the Rust API docker image. |
41df4cf
to
81f4c54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really opposed to these kinds of changes. This is being changed purely to get tests to pass, not to fix an actual problem. We should not be doing that.
I think that @dashea has fixed the symlink problem in bdcs so this should not be needed.
BDCSCli/Commands.hs
Outdated
@@ -119,7 +119,8 @@ composeCommand ctx ("tar":recipe:_) = depsolveRecipes ctx recipe >>= \r -> do | |||
let mddbPath = optMDDB $ ctxOptions ctx | |||
let repoPath = optRepo $ ctxOptions ctx | |||
printf "Creating tar of %s, saving to %s\n" recipe tarFile | |||
rawSystem "export" [mddbPath, repoPath, tarFile, tmpFile] | |||
-- this requires the bdcs.rpm to be installed | |||
rawSystem "/usr/libexec/weldr/bdcs-export" [mddbPath, repoPath, tarFile, tmpFile] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This piece of code is going to go away in the next iteration, it'll be using the API to start the compose, not calling bdcs commands directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop the Commands.hs and http-server.toml commits and everything else looks ok to me.
Note: the failure in test_images.sh is from the command:
which looks like it can't find bdcs-export.