Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
changefeedccl: match nil metrics behaviour
Previously, `validateExternalConnectionSinkURI` would validate the changefeed sink URI by creating a fake sink and passing `nil` for `metricsRecorder`. This is usually not problematic since the sink is never used. A new patch, cockroachdb#117693, is now changing this and calling `metricsBuilder` interface method inside `makeKafkaSink`. To resolve this, this patch changes getSink in `validateExternalConnectionSinkURI` to pass in `(*sliMetrics)(nil)` to avoid calling methods on a nil interface. See also: cockroachdb#117693 Release note: none Epic: none
- Loading branch information